Fix HTTP::Cookie parse quoted cookie value
#10853
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
straight-shoota
added
kind:bug
kostya
reviewed
Jun 26, 2021
| @@ -152,7 +152,12 @@ module HTTP | |||
|
|
|||
| def parse_cookies(header) | |||
| header.scan(CookieString).each do |pair| | |||
| yield Cookie.new(pair["name"], pair["value"]) | |||
| value = pair["value"] | |||
| if value.starts_with?('"') | |||
There was a problem hiding this comment.
may be check end_with also?
There was a problem hiding this comment.
That's not necessary because the regex makes sure there are delimiters on both ends.
sdogruyol
approved these changes
Jun 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HTTP::Cookies::Parsercorrectly recognizes a quoted cookie value, but it doesn't dequote when creating theHTTP::Cookieinstance. This leads to a validation error (#10485).Reported in https://forum.crystal-lang.org/t/invalid-cookie-value-error-in-kemal-how-to-fix/3427