Implement BigDecimal
's missing rounding modes
#10798
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #5714. Resolves #10599. Supersedes #7126.
The main difference with #7126 is this PR depends only on the previously unused
BigInt#unsafe_truncated_divmod
method and notNumber#digits
, which means anArray
allocation can be avoided:Similar benchmarks for
BigDecimal
s with known low scales:The existing rounding modes are also reimplemented on top of this PR. This dramatically improves
#ceil
's performance: