Use only last sub-expression of Expressions
nodes for conditional type filters
#10738
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the following run-time error:
This happens because Crystal computes the type filter from all sub-expressions of the
(x = nil; true)
node, andx = nil
produces a truthy filter onx
, even though theNil
type is never truthy; thus flow typing givesx
no type inside the if-clause. This PR restricts the filter computation to the last sub-expression.Similar errors can be triggered with while expressions; #10350 probably requires this PR.