Preserve integer sizes in NumberLiteral#int_bin_op
#10713
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Presently, the following macro raises a very surprising
Error: Arithmetic overflow
:This is because
NumberLiteral#int_bin_op
converts the operands toInt32
s via#to_i
, but this unnecessarily and incorrectly discards information about the kinds of the operands. Since by this point we've eliminated the possibility that either of the operands are floats, we can safely cast them toInt
in order to preserve their sizes.