Add free variables to "no overload matches" errors #10692
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the
forall
part to the list of overloads when a call doesn't match any overloads of a def.This is done because methods with free variables have different overload sets than methods that don't. Additionally, it avoids some confusion when the free variable names are also valid without the
forall
part. Consider:This PR changes the overload list to:
This makes it clear that the
T
in theChar
overload's type restriction shadows the generic type parameter. A similar case can be made whenT
shadows a normal type name instead.