Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Publish nightly builds to OBS #10684

Merged
merged 21 commits into from
May 13, 2021
Merged

[CI] Publish nightly builds to OBS #10684

merged 21 commits into from
May 13, 2021

Conversation

straight-shoota
Copy link
Member

The base is laid out in crystal-lang/distribution-scripts#94

Maintenance releases are automatically pushed to the unstable channel. I'm not sure if we want that, but it was simple to set up with just duplicating the OBS integration for nightlies.

Copy link
Member

@bcardiff bcardiff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was going to say that I've used dist_ for building the packages and push_ for publishing them, in that regard the job should be named push_obs_nightly. Yet, it seems I broke this rule when I added dist_bintray 😅 .

I am not sure if we should publish maintenance packages directly to unstable. I imagined that unstable packages will be used for pre releases manually. No strong opinions, maybe we should start with restoring nightlies only for now.

.circleci/config.yml Show resolved Hide resolved
.circleci/config.yml Outdated Show resolved Hide resolved
.circleci/config.yml Outdated Show resolved Hide resolved
@straight-shoota
Copy link
Member Author

I am not sure if we should publish maintenance packages directly to unstable. I imagined that unstable packages will be used for pre releases manually. No strong opinions, maybe we should start with restoring nightlies only for now.

Yes, that sounds like a better plan. With the current configuration, any ci branch would be published as an unstable release. That's not the intention of the unstable channel. Then we'd have to introduce different CI workflows for maintenance and and pre-releases to avoid pushing the former to the package repository.

@straight-shoota
Copy link
Member Author

Maybe we could try making push_obs_maintenance manually triggered? Then you would have to push a button in circleci to push to OBS, but everything would run automatically.

However, it might be better to just leave that off. We haven't been using unstable releases a lot (if at all?) and it probably doesn't hurt doing everything manually for a while until we figure we could use some assistance. It's easy to set up if necessary.

@bcardiff
Copy link
Member

bcardiff commented May 8, 2021

However, it might be better to just leave that off. We haven't been using unstable releases a lot (if at all?) and it probably doesn't hurt doing everything manually

Let's avoid pushing unstable releases for now until we figure a workflow for unstable.

.circleci/config.yml Outdated Show resolved Hide resolved
@straight-shoota straight-shoota added this to the 1.1.0 milestone May 11, 2021
@straight-shoota straight-shoota changed the title [CI] Publish nightly and unstable builds to OBS [CI] Publish nightly builds to OBS May 13, 2021
@straight-shoota straight-shoota merged commit 982fee7 into master May 13, 2021
@straight-shoota straight-shoota deleted the ci/obs-nightly branch May 13, 2021 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants