Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix imprecise Number#significant algorithm #10615

Merged
merged 1 commit into from
Apr 16, 2021
Merged

Fix imprecise Number#significant algorithm #10615

merged 1 commit into from
Apr 16, 2021

Conversation

straight-shoota
Copy link
Member

Fixes #10565

@straight-shoota straight-shoota added kind:bug A bug in the code. Does not apply to documentation, specs, etc. topic:stdlib:numeric labels Apr 9, 2021
asterite
asterite approved these changes Apr 9, 2021
View reviewed changes
Copy link
Member

@asterite asterite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@straight-shoota straight-shoota changed the title Fix impricise Number#significant algorithm Fix imprecise Number#significant algorithm Apr 9, 2021
@straight-shoota straight-shoota added this to the 1.1.0 milestone Apr 13, 2021
@straight-shoota straight-shoota merged commit b1e490f into crystal-lang:master Apr 16, 2021
@straight-shoota straight-shoota deleted the fix/number-significant branch April 16, 2021 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asterite asterite asterite approved these changes

Assignees
No one assigned
Labels
kind:bug A bug in the code. Does not apply to documentation, specs, etc. topic:stdlib:numeric
Projects
None yet
Milestone
1.1.0
Development

Successfully merging this pull request may close these issues.

Bug with Number.significant
2 participants
@straight-shoota @asterite