Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add return type restrictions to number methods / classes #10579

Merged
merged 3 commits into from
Jun 9, 2021
Merged

Add return type restrictions to number methods / classes #10579

merged 3 commits into from
Jun 9, 2021

Conversation

oprypin
Copy link
Member

@oprypin oprypin commented Apr 3, 2021

Reviewers, watch out: src/math/math.cr "Large diffs are not rendered by default."

@oprypin oprypin mentioned this pull request Apr 3, 2021
Closed
11 tasks
straight-shoota
straight-shoota approved these changes Apr 3, 2021
View reviewed changes
Copy link
Member

@straight-shoota straight-shoota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not really feasible to properly review every single change anyways. But I'd expect you made the right choices and in case something breaks, it would be easy to spot.

@straight-shoota straight-shoota added this to the 1.1.0 milestone Jun 1, 2021
@straight-shoota
Copy link
Member

Needs conflict resolution.

@straight-shoota straight-shoota merged commit 21b96da into crystal-lang:master Jun 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@straight-shoota straight-shoota straight-shoota approved these changes

Assignees
No one assigned
Labels
kind:docs kind:feature topic:stdlib:numeric
Projects
None yet
Milestone
1.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@oprypin @straight-shoota