Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in #10522 #10560

Merged
merged 1 commit into from
Apr 12, 2021
Merged

Conversation

HertzDevil
Copy link
Contributor

No description provided.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@asterite
Copy link
Member

Is there a spec that fails without this change?

@HertzDevil
Copy link
Contributor Author

The only overload of restriction_of? that actually uses the strict parameter (other than forwarding it) is GenericInstanceType#restriction_of?(GenericInstanceType, ...). In both typos the other argument is an uninstantiated generic type, so nothing should change after this.

@straight-shoota straight-shoota added kind:bug A bug in the code. Does not apply to documentation, specs, etc. topic:compiler:generics labels Mar 30, 2021
Copy link
Member

@sdogruyol sdogruyol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @HertzDevil 🙏

@straight-shoota straight-shoota added this to the 1.1.0 milestone Apr 10, 2021
@straight-shoota straight-shoota merged commit 0eec404 into crystal-lang:master Apr 12, 2021
@HertzDevil HertzDevil deleted the bug/10522 branch April 13, 2021 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:bug A bug in the code. Does not apply to documentation, specs, etc. topic:compiler:generics
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants