Fix contribution instructions #10558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
straight-shoota
added
kind:bug
bcardiff
approved these changes
May 21, 2021
There was a problem hiding this comment.
LGTM yet the make std_spec seems out of place.
There is a "The standard library" section that mention make std_spec and bin/crystal spec .... And the section changed in this PR is only for the compiler itself.
It could be merged as is no objections.
But I think it would be better to either remove the std_spec or frame it as a reminder of std specs and the alternative to run specific specs via the wrapper script.
|
Running std_spec serves as a validation that the compiler build works with stdlib. I added a note which should help clarify the purpose. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #10557