Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add file_exists? macro method #10540

Merged
merged 3 commits into from
Sep 22, 2021
Merged

Add file_exists? macro method #10540

merged 3 commits into from
Sep 22, 2021

Conversation

Sija
Copy link
Contributor

@Sija Sija commented Mar 23, 2021

Resolves #10493

@Sija Sija force-pushed the file-exists-macro branch from 678dec2 to 28e5d14 Compare March 23, 2021 20:50
@straight-shoota
Copy link
Member

What's wrong with #10489?

@Sija
Copy link
Contributor Author

Sija commented Mar 24, 2021

@straight-shoota Nothing, I forgot about its existence 😅

@Sija Sija closed this Apr 10, 2021
@toddsundsted
Copy link
Contributor

toddsundsted commented Jul 18, 2021 •
edited
Loading

@Blacksmoke16 @Sija i don't think either of these were ever merged. i blew away the branch underlying my PR a short time ago, so my PR was closed. i'd still like to see this change, however (if you want to re-open this PR).

@Sija Sija reopened this Jul 18, 2021
@Sija Sija force-pushed the file-exists-macro branch from 28e5d14 to cc42175 Compare July 18, 2021 21:04
@Sija
Copy link
Contributor Author

Sija commented Jul 18, 2021

@toddsundsted Sure, I reopened this PR as suggested + it's rebased and ready for review.
/cc @straight-shoota

@Sija
Copy link
Contributor Author

Sija commented Sep 17, 2021

ping 🏓

beta-ziliani
beta-ziliani approved these changes Sep 17, 2021
View reviewed changes
Copy link
Member

@beta-ziliani beta-ziliani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Sija !

@beta-ziliani beta-ziliani added this to the 1.2.0 milestone Sep 17, 2021
@straight-shoota straight-shoota merged commit 7a68793 into crystal-lang:master Sep 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@beta-ziliani beta-ziliani beta-ziliani approved these changes

@straight-shoota straight-shoota straight-shoota approved these changes

Assignees
No one assigned
Labels
kind:feature topic:stdlib:macros
Projects
None yet
Milestone
1.2.0
Development

Successfully merging this pull request may close these issues.

Add #file_exists? Top-level Macro Method
5 participants
@Sija @straight-shoota @toddsundsted @beta-ziliani @HertzDevil