-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add stricter checks for arguments to macro methods on AST nodes #10498
Merged
straight-shoota
merged 10 commits into
crystal-lang:master
from
HertzDevil:bug/macro-argument-checks
Aug 24, 2021
Merged
Add stricter checks for arguments to macro methods on AST nodes #10498
straight-shoota
merged 10 commits into
crystal-lang:master
from
HertzDevil:bug/macro-argument-checks
Aug 24, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
straight-shoota
approved these changes
Mar 18, 2021
straight-shoota
added
kind:bug
A bug in the code. Does not apply to documentation, specs, etc.
kind:refactor
topic:compiler:semantic
labels
Mar 18, 2021
beta-ziliani
approved these changes
Aug 20, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
kind:bug
A bug in the code. Does not apply to documentation, specs, etc.
kind:refactor
pr:needs-review
topic:compiler:semantic
topic:lang:macros
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, Crystal's macro interpreter is very lax when it comes to macro methods on AST nodes:
Other times, the error messages related to parameter-argument matching are inconsistent with other places in the compiler:
This PR fixes all of these with a new
interpret_check_args
macro, replacing the oldinterpret_argless_method
and friends; this shouldn't break any code that already obeys the API docs onsrc/compiler/crystal/macros.cr
.It's best to review each commit in isolation instead of all at once. Error messages for AST node type mismatches (
argument must be a T, not U
) will be covered later.