Add Slice#hexdump(io : IO) overload
#10496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
I would probably prefer to reduce the implementation of #hexdump to calling hexdump(io). String size calculation still makes sense, of course. But we can save two separate loop implementations. The overhead is an additional IO allocation, but that's negligible and IMO more concise code is more worth than a slight optimization in this piece.
Comment on lines
+283
to
+285
| io = IO::Memory.new | ||
| Bytes.empty.hexdump(io).should eq(0) | ||
| io.to_s.should eq("") |
There was a problem hiding this comment.
Using String.build might make these examples a bit more concise.
|
I think that it might actually make sense to have hexdump not allocate an IO if it's not too hard (well, it's already in this PR). We do a similar optimization for converting numbers into strings. |
straight-shoota
approved these changes
Apr 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #10495.
The private method
hexdump_linerefactors most of the original overload and theIOoverload's bodies together; this leads to a slight speedup even for the overload that returns aString. The new overload flushes theIOand returns the number of bytes written, similar toBase64.encode(data, io : IO).Benchmark and results. (The oddity with N = 0 seems to be that the benchmark program doesn't inline
bytes.hexdumpinto the first report block's body.)