Split HTTP::Cookies.from_headers
into separate methods for server/client
#10486
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HTTP::Cookies.from_headers
populates aCookie
collection from HTTP headers. It parses bothCookie
andSet-Cookie
headers, which seems odd. They are distinct features you really never want to use in combination (you can't have both in the same set of headers).In practice it means
HTTP::Client
accepts cookies defined byCookie
header andHTTP::Server
accepts cookies defined bySet-Cookie
header. Both is very confusing and could even offer an opportunity for abuse by circumventing the correct header mechanincs.This patch deprecates
{fill_,}from_headers
and replaces it with distinct{fill_,}from_client_headers
and{fill_,}from_server_headers
methods.