Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename "sigfault" to "segfault" #10454

Closed
wants to merge 1 commit into from

Conversation

j8r
Copy link
Contributor

@j8r j8r commented Feb 28, 2021

"sigfault" doesn't exist: this is either "segfault" for Segmentation fault, or SIGSEGV.

When I was starting to say "sigfault" and realized this word doesn't exist, I knew it was time to change this 😅

Perhaps it is a portmanteau for "Segmentation fault signal"?

@straight-shoota straight-shoota added kind:bug A bug in the code. Does not apply to documentation, specs, etc. kind:refactor labels Feb 28, 2021
@hugopl
Copy link
Contributor

hugopl commented Mar 4, 2021

This conflicts with #10463, that remove all these files.

@j8r
Copy link
Contributor Author

j8r commented Mar 4, 2021

Not really, the renaming isn't done in there.

By the way, it will be better to merge this first, sooner the better, so the segflaut refactor PR (still WIP as writing) can be rebased against master, and be ready for review with this changes in the future.

@asterite
Copy link
Member

asterite commented Mar 4, 2021

it will be better to merge this first

Not really. This is a good PR. But the changes aren't visible to anyone not reading the code.

The other PR is visible and useful to anyone compiling the compiler, or any program. So I wouldn't hurry merging this PR when all these changes will be undone by the other PR.

@straight-shoota
Copy link
Member

Yes, #10463 should be merged first/instead.

@j8r
Copy link
Contributor Author

j8r commented Mar 10, 2021

Yes, the linked PR now includes the renaming too.

@straight-shoota
Copy link
Member

This was resolved by #10463.

Nevertheless thank you, @j8r

@j8r j8r deleted the rename-to-segfault branch April 14, 2021 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:bug A bug in the code. Does not apply to documentation, specs, etc. kind:refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants