Add JSON/YAML serialization to URI
#10404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think these should live in "uri/json" and "uri/yaml" respectively. It doesn't break now, but nothing prevents us in the future from type-checking the arguments even before you call the methods (a bit more reliable) and then it will break. |
|
Can we delay this until it becomes necessary if ever? I know we do the same thing for other types, but it just feels like an unneccesary burdon on usability if you have to require these simple converter methods explicitly. |
sdogruyol
approved these changes
Mar 7, 2021
caspiano
approved these changes
Mar 21, 2021
|
I am with Ary. I think we must keep it consistent with the rest of the lib. We can discuss later a refactor here and there. |
jhass
approved these changes
Sep 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
URI can be trivially serialized to a string in both JSON and YAML, so this adds the necessary conversion methods.
Note that this does not make
require "json"/require "yaml"mandatory when usingrequire "uri". The methods just won't work unless JSON/YAML are also required.