Compiler: only make Pointer(T)#value= stricter for generic arguments
#10224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asterite
added
kind:bug
| @@ -1058,7 +1058,7 @@ class Crystal::Call | |||
| args["self"] = MetaVar.new("self", self_type) | |||
| end | |||
|
|
|||
| strict_check = body.is_a?(Primitive) && body.name == "proc_call" | |||
| strict_check = body.is_a?(Primitive) && (body.name == "proc_call" || body.name == "pointer_set") | |||
There was a problem hiding this comment.
Wouldn't it make sense to remove this variable as its only used in the conditional which could be replaced by case body.as?(Primitive).try &.name?
There was a problem hiding this comment.
I would like to make it clear a strict check is happening.
There was a problem hiding this comment.
Or maybe yes, I don't know. I don't think it matters much, plus I won't be at the computer for a while
bcardiff
approved these changes
Jan 8, 2021
This was referenced Aug 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative to #10214 (partially reverts that one)
Fixes #10211
This makes the compiler apply the logic of #10214 to only
Pointer(T)#value=, preventing incorrect memory from being assigned. In every other case it will work as it used to work (in a more permissive way).In a way, this is similar to how assigning
Array(Array(Int32))toArray(Array(String | Int32))is invalid, but passing the former to a method that restricts it by the latter works.Pointer(T)#value=is like an assignment and it should be treated in a more strict way.