Remove duplicated sort related specs
#10208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you please leave a simple positive spec for every method? Like |
|
@straight-shoota They are still in specs of course. |
straight-shoota
approved these changes
Jan 6, 2021
|
ping. Please review this for #10163 |
bcardiff
approved these changes
Jan 29, 2021
|
Looks like it only lacks a |
makenowjust
force-pushed
the
reduce-sort-spec
branch
from
fe781b0 to
e3da45d
Compare
|
@rdp CI error message is I will rebase this to re-run CI. I wish it makes CI green. |
|
Please! #10163 is pending due to this. |
|
Thank you @straight-shoota and @bcardiff. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #10163 (comment)
@straight-shoota Could you merge this in 5 minutes? If it is possible, I will rebase #10163 soon.