-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup CIs #10078
Cleanup CIs #10078
Conversation
master is already formatted.
We can probably remove the entire |
If I understand correctly the logic, we can remove all One thing remaining is to change the env var |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is PR as it is is dropping the publishing of docs on each master commit. We can add the AWS_ACCESS_KEY_ID
and AWS_SECRET_ACCESS_KEY
secrets to github but the appropriate job would still be needed.
Where is the script that does it? I don't see it. |
Oh, I didn't even realizes that dev docs are actually updated after each commit to master. I had in mind that this happens with the nightly release. |
Docs are built in test_linux job ( |
Thanks @straight-shoota , Circle CI configuration is quite powerful! What do we do, do we move |
Which parts of |
|
Okay, but that's in this PR. So there's nothing left for "move test_all_platforms to GitHub Actions at the end". |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I iterated a bit in the configuration. I restored the commented test_darwin because they are disabled temporarily. I also moved the if
to job level.
There are 36 CI jobs for each commit landing in master (!). Obviously, it has a visibility impact for the users, and unnecessary use resources.
After looking at them, some can be removed:
Be free for core members to comment on this PR.
Note: I don't see in the Circle CI config how to disable the jobs running on a push/PR, maybe it is available on the Web console.