Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup CIs #10078

Merged
merged 10 commits into from
Dec 18, 2020
Merged

Cleanup CIs #10078

merged 10 commits into from
Dec 18, 2020

Conversation

j8r
Copy link
Contributor

@j8r j8r commented Dec 14, 2020

There are 36 CI jobs for each commit landing in master (!). Obviously, it has a visibility impact for the users, and unnecessary use resources.

After looking at them, some can be removed:

  • Travis CI
  • check_format on Circle CI

Be free for core members to comment on this PR.

Note: I don't see in the Circle CI config how to disable the jobs running on a push/PR, maybe it is available on the Web console.

README.md Outdated Show resolved Hide resolved
@straight-shoota
Copy link
Member

We can probably remove the entire test_all_platforms workflow on circleci and only keep the release related workflows.

@j8r
Copy link
Contributor Author

j8r commented Dec 14, 2020

If I understand correctly the logic, we can remove all test_* from Circle CI and keep the dist_*? At least, some like Linux and preview_mt.

One thing remaining is to change the env var TRAVIS_OS_NAME naming.

Copy link
Member

@bcardiff bcardiff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is PR as it is is dropping the publishing of docs on each master commit. We can add the AWS_ACCESS_KEY_ID and AWS_SECRET_ACCESS_KEY secrets to github but the appropriate job would still be needed.

@j8r
Copy link
Contributor Author

j8r commented Dec 15, 2020

Where is the script that does it? I don't see it.
Also, I need the S3 bucket in question.

@straight-shoota
Copy link
Member

Oh, I didn't even realizes that dev docs are actually updated after each commit to master. I had in mind that this happens with the nightly release.

@straight-shoota
Copy link
Member

Docs are built in test_linux job (bin/ci runs make docs) and then sync_docs_s3 is responsible for pushing it to s3.

@j8r
Copy link
Contributor Author

j8r commented Dec 15, 2020

Thanks @straight-shoota , Circle CI configuration is quite powerful!

What do we do, do we move test_all_platforms to GitHub Actions at the end? It depends if the goal is also to move progressively from Circle CI to Actions.

@straight-shoota
Copy link
Member

Which parts of test_all_platforms is currently not in Github Actions?

@j8r
Copy link
Contributor Author

j8r commented Dec 18, 2020

sync_docs_to_s3 is not in GitHub Actions, that's it.

@straight-shoota
Copy link
Member

Okay, but that's in this PR. So there's nothing left for "move test_all_platforms to GitHub Actions at the end".

Copy link
Member

@bcardiff bcardiff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I iterated a bit in the configuration. I restored the commented test_darwin because they are disabled temporarily. I also moved the if to job level.

@bcardiff bcardiff merged commit 12bf665 into crystal-lang:master Dec 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants