Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

formatter: bad comment indentation in case's else, when inline comment after else #6391

Closed
bew opened this issue Jul 15, 2018 · 1 comment
Closed

formatter: bad comment indentation in case's else, when inline comment after else #6391

bew opened this issue Jul 15, 2018 · 1 comment
Labels
kind:bug A bug in the code. Does not apply to documentation, specs, etc. topic:compiler topic:tools:formatter topic:tools

Comments

@bew
Copy link
Contributor

bew commented Jul 15, 2018 •
edited
Loading

This code:

case expr
when expr
else # inline-comment
  # Some comment
  some_code
end

Is incorrectly formatted to:

case expr
when expr
else # inline-comment
# Some comment         <---- no indentation
  some_code
end
makenowjust added a commit to makenowjust/crystal that referenced this issue Jul 16, 2018
@makenowjust
Format: fix comment indentation in case's else
0c105e7 
Fix crystal-lang#6391
@makenowjust makenowjust mentioned this issue Jul 16, 2018
Merged
@RX14 RX14 added kind:bug A bug in the code. Does not apply to documentation, specs, etc. topic:tools:formatter labels Jul 16, 2018
RX14 pushed a commit that referenced this issue Jul 16, 2018
@makenowjust @RX14
Format: fix comment indentation in case's else (#6393)
466e0a2 
Fix #6391
@bew
Copy link
Contributor Author

bew commented Jul 16, 2018

Thanks @makenowjust & @RX14!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind:bug A bug in the code. Does not apply to documentation, specs, etc. topic:compiler topic:tools:formatter topic:tools
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@RX14 @bew