Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify folder name for generated documentation #4918

Closed
vladfaust opened this issue Sep 3, 2017 · 7 comments
Closed

Specify folder name for generated documentation #4918

vladfaust opened this issue Sep 3, 2017 · 7 comments

Comments

@vladfaust
Copy link
Contributor

vladfaust commented Sep 3, 2017

GitHub Pages allow to configure source. It can be either master or master/docs. It would be convenient if a developer could pass a folder name to crystal docs like crystal docs -f docs.

Or maybe even change the default folder name to docs. Plural form is more familiar to me as a developer. Nobody says "read the doc", they usually say "read the docs".

@vladfaust vladfaust changed the title Specify folder for documentation Specify folder name for generated documentation Sep 3, 2017
@vladfaust
Copy link
Contributor Author

Managed to automatically deploy to gh-pages after Travis build: travis.yml.

But still think that docs is a better name.

@RX14
Copy link
Member

RX14 commented Sep 4, 2017

This might still be something we want to implement.

@straight-shoota
Copy link
Member

I'd also prefer docs as default folder. Though it's debatable, I doubt that one is really preferable over the other.
Judging from a few examples what other projects are using the plural seems a bit more common. But in the end it probably won't matter much.
I'd just argue that the command is called crystal docs so it would be neat to create a folder called docs.

It should definitely be possible to configure the output directory. Some projects might want to use the docs/doc folder for handwritten documentation and put the autogenerated API docs into apidocs for example. Or an entirely different location, e.g. for automatic deployment to the docs site.

@asterite
Copy link
Member

asterite commented Sep 8, 2017

Let's change it to docs

@asterite
Copy link
Member

asterite commented Sep 8, 2017

But also let's add an option to configure it. But if docs is more common (and I think it is), let's change both things.

@bcardiff
Copy link
Member

bcardiff commented Sep 8, 2017

People interested in publishing docs as gh-pages might like checking https://github.com/bcardiff/ghshard .

Publishing docs is more than publishing just the master. The other stories around docs I remember where hooking some artifact to allow redirections to last current stable version (and highlight outdated one) and changing the index document from README.md to DOCS.md or something more appropriate for docs than repos.

It might be useful to have this other scenarios into account to decide if the options should be as command line arguments or maybe in shards.yml o some other configuration file. I'm ok if all is configurable via command line arguments though.

@straight-shoota
Copy link
Member

I am using a bash script for automatically generating and deploying API documentation through CI (or manually): autodeploy-docs. It is not limited to Crystal documentation, though also not that deeply integrated with shards but uses git tags.

edwardloveall added a commit to edwardloveall/lucky_record that referenced this issue Jun 18, 2018
Crystal changed the default doc folder to "docs"
crystal-lang/crystal#4918
paulcsmith pushed a commit to luckyframework/lucky_record that referenced this issue Jun 18, 2018
Crystal changed the default doc folder to "docs"
crystal-lang/crystal#4918
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants