Add ANSI syntax highlighting to overload matching errors

[postmodern]

Feature Request

In order to improve readability of the overload matching error, the list of overloaded method signatures could be syntax highlighted with ANSI color codes. This would improve the readability of rather verbose method signatures.

Overloads are:
 - Test#test(arg1 : Int32, arg2 : Int32, arg3 : UInt8)
 - Test#test(arg1 : Int, arg2 : Int32, arg3 : Int::Unsigned)
 - Test#test(arg1 : UInt32, arg2 : UInt32, arg3 : UInt32, &block : (UInt32, UInt32, UInt32 -> Int64))

Elements we could highlight:

• ,
• :
• ( )
• & ->
• #
• argument name
• Type names

I will let others decide what color scheme should be used, or whether ANSI bold or bright colors should be used to highlight specific elements in the method signature.

[wyhaines]

FWIW, I have a PR that I am playing with to do both this and syntax highlighting of the code lines in a backtrace.

Currently:

[postmodern]

Would also be nice to syntax highlight type unions ((Int32 | String | UInt32)). Highlighting the (, ), and | chars in a different color than the type names would help visually break it up.

[wyhaines]

I agree and I will make those additions tomorrow, after I sleep, and then test it on some real code, and then I will drop the images into this thread.

[HertzDevil]

Duplicate of #11106.

[postmodern]

#11106 seems to be about indicating the compatible arguments to find the optimal overload; which is a neat idea. This feature request is just to add basic syntax highlighting to make it easier to read method signatures and type signatures in error output.

[vlazar]

Also good to keep this comment in mind #11106 (comment)

[straight-shoota]

Maybe we should really just use Crystal::SyntaxHighlighter::Colorize for all code that is printed by the compiler, including method signatures and type unions etc.

[wyhaines]

This is essentially what the PR that I am working on does. Kirk Haines

…

On Thu, Jan 20, 2022, 5:53 AM Johannes Müller ***@***.***> wrote: Maybe we should really just use Crystal::SyntaxHighlighter::Colorize for all code that is printed by the compiler, including method signatures and type unions. — Reply to this email directly, view it on GitHub <#11755 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAADFQAJYRYX2LA4BKFGWLTUXAAWDANCNFSM5MLUOCKA> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>. You are receiving this because you commented.Message ID: ***@***.***>