Refactor changes to one method

crystal-lang · Nov 27, 2023 · 7d11346 · 7d11346
1 parent f10f63d
commit 7d11346
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 11 deletions.
diff --git a/src/crystal/system/unix/process.cr b/src/crystal/system/unix/process.cr
@@ -15,13 +15,6 @@ struct Crystal::System::Process
   end
 
   def wait
-    {% if flag?(:interpreted) %}
-      # Block interpreter until child process is terminated
-      r_pid = LibC.waitpid(pid, out exit_code, 0)
-      @channel.send(exit_code)
-      # Close channel properly
-      @channel.close
-    {% end %}
     @channel.receive
   end
 

diff --git a/src/crystal/system/unix/signal.cr b/src/crystal/system/unix/signal.cr
@@ -225,10 +225,10 @@ module Crystal::System::SignalChildHandler
   def self.wait(pid : LibC::PidT) : Channel(Int32)
     channel = Channel(Int32).new(1)
     {% if flag?(:interpreted) %}
-      # Returns channel immediately when interpreted
-      # Waiting for child process in interpreted code
-      # does not rely on signal SIGCHLD and it's handled
-      # in ::Crystal::System::Process.wait
+      # Blocking wait until child process exits
+      r_pid = LibC.waitpid(pid, out exit_code, 0)
+      channel.send(exit_code)
+      channel.close
       return channel
     {% end %}