Catch assertion failures in stdlib coverage #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes an assertion failure in the stdlib file compiler/crystal/macros/methods.cr
nobodywasishere
approved these changes
Dec 9, 2024
devnote-dev
approved these changes
Dec 9, 2024
|
Would you be able to update the test ci so that it runs |
Are you asking in relation to this PR, or just in general? |
This PR - as we're now passing stderr from the stdlib test subprocesses, it's outputting this warning a lot |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the stdlib coverage test triggers an assertion failure, segfault, or other unusual exit code, the whole test run is aborted.
Also, fix an assertion failure I found.