Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crystal next support #72

Merged
merged 2 commits into from
Dec 27, 2017
Merged

Crystal next support #72

merged 2 commits into from
Dec 27, 2017

Conversation

veelenga
Copy link
Member

@veelenga veelenga commented Nov 4, 2017

https://github.com/crystal-lang/crystal/releases/tag/0.24.0 (pre-release)

Shouldn't be merge until the official release

@veelenga
Copy link
Member Author

veelenga commented Dec 25, 2017

https://github.com/crystal-lang/crystal/releases/tag/v0.24.1 is out, build pass. Ready for review/merge.

@veelenga veelenga removed the blocked label Dec 25, 2017
@jwoertink jwoertink requested review from jwoertink and removed request for jwoertink December 26, 2017 16:56
@jwoertink
Copy link
Collaborator

Looks good to me. Didn't there used to be a button to approve? I'm not seeing it, but I approve the changes 👍

Copy link
Contributor

@icyleaf icyleaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It can merge now 🌟

@veelenga veelenga merged commit 6dabbef into master Dec 27, 2017
@veelenga veelenga deleted the feat/crystal-0.24 branch December 27, 2017 08:04
@veelenga
Copy link
Member Author

Should we prepare a new release for this?

@oprypin
Copy link
Contributor

oprypin commented Dec 31, 2017

Why yes, you should

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants