Refactors before 1.7 release #555
Conversation
Sija
force-pushed
the
refactors-before-1.7-release
branch
2 times, most recently
from
383583c to
c573bb3
Compare
Sija
force-pushed
the
refactors-before-1.7-release
branch
3 times, most recently
from
57e669d to
4e5e0bb
Compare
Sija
force-pushed
the
refactors-before-1.7-release
branch
from
4e5e0bb to
cd144e9
Compare
| describe Documentation do | ||
| subject = Documentation.new |
There was a problem hiding this comment.
only now noticed that the rule name is kinda off:
Ameba::Rule::Documentation::Documentation
There was a problem hiding this comment.
Honestly, I always feel uncomfortable with these massive refactorings across the codebase. In most big projects, contributions that involve refactoring are often discouraged because many suggestions tend to be subjective and, in some cases, introduce hidden issues.
I’m okay with this one, however, wanna add that refactoring just for the sake of cleaner code can sometimes create unnecessary churn and increasing the risk of introducing subtle bugs, especially before the release.
|
@veelenga I understand your sentiment, and in general I'm against such big PRs, yet once in a while I tend to gather all smaller (and thus with no or very slight chances of regressions) changes into one batch to save us time and energy that would go into reviewing these independently. |
No description provided.