Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Style/RedundantSelf rule #547

Merged
merged 2 commits into from
Jan 30, 2025
Merged

Add Style/RedundantSelf rule #547

merged 2 commits into from
Jan 30, 2025

Conversation

Sija
Copy link
Member

@Sija Sija commented Jan 24, 2025

Resolves #535

@Sija Sija added the rule label Jan 24, 2025
@Sija Sija added this to the 1.7.0 milestone Jan 24, 2025
@Sija Sija requested a review from veelenga January 24, 2025 22:51
@Sija Sija self-assigned this Jan 24, 2025
@Sija Sija force-pushed the redundant-self-rule branch from 54dc17b to a425fd9 Compare January 29, 2025 20:19
@Sija Sija requested review from veelenga and removed request for veelenga January 29, 2025 20:20
Copy link
Member

@veelenga veelenga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one. Added some unblocking comments

Copy link
Member

@veelenga veelenga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Sija Sija merged commit 59c11ff into master Jan 30, 2025
3 of 4 checks passed
@Sija Sija deleted the redundant-self-rule branch January 30, 2025 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rule Style/RedundantSelf
3 participants