Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crystal 1.4 compatibility #259

Merged
merged 8 commits into from
Apr 5, 2022
Merged

Crystal 1.4 compatibility #259

merged 8 commits into from
Apr 5, 2022

Conversation

veelenga
Copy link
Member

@veelenga veelenga commented Mar 11, 2022 •
edited by Sija
Loading

Sija
Sija reviewed Mar 11, 2022
View reviewed changes
src/ameba/tokenizer.cr Outdated Show resolved Hide resolved
src/ameba/tokenizer.cr Show resolved Hide resolved
@straight-shoota straight-shoota mentioned this pull request Mar 23, 2022
Open
@Sija
Copy link
Member

Sija commented Apr 2, 2022

@veelenga ping, Crystal 1.4.0 release is just around the corner

@Sija Sija added this to the 0.15.0 milestone Apr 2, 2022
@veelenga
Copy link
Member Author

veelenga commented Apr 3, 2022

Sure, i will finish this soon

@veelenga veelenga marked this pull request as ready for review April 3, 2022 16:24
@veelenga veelenga requested a review from Sija April 3, 2022 16:24
@veelenga veelenga self-assigned this Apr 3, 2022
Sija
Sija reviewed Apr 3, 2022
View reviewed changes
src/ameba/rule/style/redundant_begin.cr Outdated Show resolved Hide resolved
spec/ameba/rule/lint/empty_ensure_spec.cr Outdated Show resolved Hide resolved
spec/ameba/rule/lint/shadowed_exception_spec.cr Outdated Show resolved Hide resolved
Sija
Sija reviewed Apr 3, 2022
View reviewed changes
spec/ameba/rule/lint/empty_ensure_spec.cr Outdated Show resolved Hide resolved
src/ameba/rule/style/redundant_begin.cr Outdated Show resolved Hide resolved
@veelenga veelenga force-pushed the fix/crystal-nightly branch from f2eefb8 to 8d47301 Compare April 3, 2022 21:59
Sija
Sija approved these changes Apr 3, 2022
View reviewed changes
Copy link
Member

@Sija Sija left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀 (I'd wait with release though until Crystal 1.4.0 comes out)

@veelenga veelenga changed the title Pass on crystal-nightly Crystal 1.4 compatibility Apr 4, 2022
@straight-shoota
Copy link
Contributor

This change works with the Crystal 1.4 release branch, so it should be good to merge. I wouldn't expect any breaking changes for the release.

@Sija Sija merged commit 734e55f into master Apr 5, 2022
@Sija Sija deleted the fix/crystal-nightly branch April 5, 2022 12:49
@straight-shoota straight-shoota mentioned this pull request Apr 7, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sija Sija Sija approved these changes

Assignees

@veelenga veelenga

Labels
infrastructure
Projects
None yet
Milestone
0.15.0
Development

Successfully merging this pull request may close these issues.
3 participants
@veelenga @Sija @straight-shoota