Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adapt proofs to use transparent integers #756

Merged
merged 9 commits into from
Jan 25, 2025
Merged

Adapt proofs to use transparent integers #756

merged 9 commits into from
Jan 25, 2025

Conversation

karthikbhargavan
Copy link
Contributor

This PR adapts the libcrux code and proofs to use the transparent-integers branch of hax.
In particular, every integer constant is now written in the new style:

  • 0uy becomes mk_u8 0
  • 0us becomes mk_u16 0
  • 0s becomes mk_i16 0
  • 0ul becomes mk_u32 0
  • 0l becomes mk_i32 0

@karthikbhargavan karthikbhargavan mentioned this pull request Jan 18, 2025
Merged
@karthikbhargavan karthikbhargavan marked this pull request as ready for review January 24, 2025 12:37
@karthikbhargavan karthikbhargavan requested a review from a team as a code owner January 24, 2025 12:37
@karthikbhargavan
Copy link
Contributor Author

Merged main and fixed up extraction.

franziskuskiefer
franziskuskiefer approved these changes Jan 25, 2025
View reviewed changes
Copy link
Member

@franziskuskiefer franziskuskiefer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, let's get this in

@franziskuskiefer franziskuskiefer merged commit a177c4d into main Jan 25, 2025
62 checks passed
@franziskuskiefer franziskuskiefer deleted the transparent-integers branch January 25, 2025 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@franziskuskiefer franziskuskiefer franziskuskiefer approved these changes

@jschneider-bensch jschneider-bensch Awaiting requested review from jschneider-bensch

Assignees

@karthikbhargavan karthikbhargavan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@karthikbhargavan @franziskuskiefer @W95Psp