fix: timer reset #51
Merged
fix: timer reset #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k-matsuzawa
requested review from
seki-cg,
ayuri-kn,
fukushima-cg and
mengzhuang-jin-cg
fukushima-cg
approved these changes
May 16, 2022
| if !t.timer.Stop() { | ||
| select { // cleanup | ||
| case <-t.timer.C: | ||
| default: |
There was a problem hiding this comment.
default はあまり意味はないですか？
if !..Stop() 句で入っている時点で必ず timer.C から読み出せる？
There was a problem hiding this comment.
関連するIssue等を読み直してみましたが、確かに Stop()==false の時点で（かつTimerの受信側のgoroutineのselectで読み出しする場合）必ず読み出せるようです。（ややこしい、、）
golang/go#27169
コメントを残して不要な処理を削除するか、分かりやすさを重視してこのままで行くか、どちらがいいでしょう？（迷い中）
There was a problem hiding this comment.
このままでいいかと思います。
select ... default 句は golang のイディオム的な意味合いも強そうなので、意図がわからないということもなさそうですので。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposal
、Timer通知をそれぞれ独立したgoroutineで行うように修正