-
Notifications
You must be signed in to change notification settings - Fork 245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat:(label) Improved address label user experience #1978
Merged
Merged
Changes from all commits
Commits
Show all changes
35 commits
Select commit
Hold shift + click to select a range
ce0d1cf
feat:(label) improved address label ux
otkstudio 33ecc24
Merge branch 'master' into improved-address-labels
moneymanolis cd0eb5f
service icon alignment
moneymanolis c74e155
Merge branch 'improved-address-labels' of github.com:cryptoadvance/sp…
moneymanolis 2b77b1e
Merge branch 'master' into improved-address-labels
moneymanolis d5a0c16
make it work on firefox
moneymanolis 4488033
Merge branch 'improved-address-labels' of github.com:cryptoadvance/sp…
moneymanolis 05171c4
fix:(label) fix spacing of the service logo on tx table
otkstudio 4649727
fix:(label) fix sizing of service icon within label
otkstudio 6cd2f2e
fix:(label) fix table not scaling to label width
otkstudio c323949
Merge branch 'master' into improved-address-labels
moneymanolis e689e8c
add / change titles
moneymanolis 3b60fe7
draft - copy button in address list
moneymanolis 03f32b0
Merge branch 'master' into improved-address-labels
moneymanolis 428dbab
Merge branch 'master' into improved-address-labels
moneymanolis 96b9b7b
Merge branch 'improved-address-labels' of github.com:cryptoadvance/sp…
moneymanolis 91c903a
click away from edit section cancels editing
moneymanolis eb5f68f
check whether addressesTableComponent is available
moneymanolis 9204952
solution for spacebar bug in firefox
moneymanolis 7f36482
address data and tx table listeneres
moneymanolis 5eaae52
make pressing ENTER work
moneymanolis 1ff8fb3
Merge branch 'master' into improved-address-labels
moneymanolis 27d44e3
add address to tx info
moneymanolis 8dc794c
typo
moneymanolis fbd7d95
firefox fixes
moneymanolis 1607e03
prevent bubbling
moneymanolis 0f48852
check whether there is an address-label for txlist
moneymanolis b4f1abf
select all only at edit start
moneymanolis 809cec7
revert copy address button
moneymanolis d6e08db
add editable attribute
moneymanolis acb4829
disable editing for receive page
moneymanolis fd0eb4d
change cursor to default in non-editable mode
moneymanolis eb61708
disable bubbling for update & cancel btns
moneymanolis ce20e87
no need to check for specific event targets anymore
moneymanolis b673168
Merge branch 'master' into improved-address-labels
moneymanolis File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure whether it changes anything to have this - in any case center is an invalid property for vertical-align