-
Notifications
You must be signed in to change notification settings - Fork 241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extension callbacks refactoring and middleware implementation #1939
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for specter-desktop-docs canceled.
|
When you refactor the locations of the services, can you also solve #1935 ? |
fix tests for services move to specterext and complete
k9ert
force-pushed
the
extension_callbacks
branch
from
October 26, 2022 13:06
893a626
to
f9cd800
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation of callbacks has a major flaw: The callback can collect results from different extensions but it can't let extensions modify the results of former extension-modifications.
So this PR does those things:
ServiceManager
to anExtensionManager
including references from services to extensionsreturn_styles
. The string representations has been modified to be using classesreturn_style
called "middleware" and the old-style will be calleddict
:dict
will return a dict where the extension_id will be used as key and the returnvalue as a value (to be renamed to "collect")middleware
will assume that something will be passed to the callback as value and the returnvalue (might be the same or different) will be passed to the next callback of the next extension until the last extension's returnvalue will be returned by the execute_ext_callback-method.depends
Attribute with a list of Extension-classes. The callbacks will get called so that the dependency tree and the sort-priority is respected.On top of those changes, a new graphql-extension has been created:
/graphql
endpointmiddleware
which starts as an empty array and the extensions can add fields to it./graphql
) like: