migrating to hwi 2.1.0

[k9ert]

Jade is currently not fully supported, see #1635 and this get fixed via migrating to hwi 2.1.0.
This is WIP:

• Remove custom TrezorClient
• Remove custom KeepKey client
• Reapply changes to jade client
• Track ModuleNotFoundError: hwilib.devices.trezorlib.transport.bridge bitcoin-core/HWI#601

We need a bit more Manual testing for this. Help very much appreciated. If you can check one of these boxes, please post in the comments:

• Manual Test with Trezor One
  • device-creation
  • signing a TX segwit
  • signing a multisig TX segwit
  • msg-signing
• Manual Test with Keepkey
  • device-creation
  • signing a TX segwit
  • signing a multisig TX segwit
  • msg-signing
• Manual Test with Bitbox02
  • device-creation
  • signing a TX segwit
  • msg-signing
• Manual Test with Ledger
  • device-creation
  • signing a TX segwit
  • msg-signing
• Manual Test with Jade
  • device-creation
  • signing a TX segwit
  • msg-signing
• Manual Test with Specter-DIY (via USB obviously)
  • device-creation
  • signing a TX segwit
  • msg-signing

[netlify]

✅ Deploy Preview for specter-desktop-docs ready!

Name	Link
🔨 Latest commit	3b4ae94
🔍 Latest deploy log	https://app.netlify.com/sites/specter-desktop-docs/deploys/62c3131812ebbc0009bdc5c2
😎 Deploy Preview	https://deploy-preview-1693--specter-desktop-docs.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site settings.

[relativisticelectron]

I found in #1688 that the error message has changed and I need to replace

specter-desktop/tests/test_hwibridge.py

Line 114 in b5bf6f1

assert {

by 535100b

    assert {
            'error': {
                'code': -32000,
                'message': "Internal error: HWIBridge.enumerate() got an unexpected keyword argument 'non_existing_parameter'."
            },
            'id': 1,
            'jsonrpc': '2.0'
            } == json.loads(req.data)

Do I assue correctly that this error is due to the newer version of hwi?

[k9ert]

Do I assue correctly that this error is due to the newer version of hwi?

I would assume so.

[k9ert]

Ok, so i don't have a ledger and for some reason my old keepkey doesn't work anymore for testing. I would love to at least test the keepkey, though as i removed the keepkey specific code which is no longer needed.
Anyone with a keepkey can test that?

[k9ert]

I didn't get any feedback from keepkey folks. Also no feedback from their support in order to get my keepkey back to work. I'm a bit annoyed, i have to say.

[evliu]

looks like hwi 2.1.1 has been released with small updates. might as well jump ahead
https://github.com/bitcoin-core/HWI/releases/tag/2.1.1

[k9ert]

Doesn't look like it get any better with Keepkey. Not sure about HWI 2.1.0. I'll definitely move this forward this week.

[k9ert]

Ok, i think we should merge this and maybe shortly after this is released upgrade to HWI 2.1.1. I've tested it with 2.1.0, it has some major changes on our side and it's beneficial to ask people if they have issues to switch versions in order to figure out where an issue is coming from.

I think i've discussed the details of this with @moneymanolis and it seems that @relativisticelectron looked into it but we don't have a formal approval yet. Can one of you approve this?

[relativisticelectron]

I am surprised you did not run into the seemingly changed error message:
#1693 (comment)

I think i've discussed the details of this with @moneymanolis and it seems that @relativisticelectron looked into it but we don't have a formal approval yet. Can one of you approve this?

Sorry, I did not test hwi 2.1.0. However I could test hwi 2.1.0 with Ledger, as soon as I have time.

[k9ert]

I am surprised you did not run into the seemingly changed error message:

I spent some time trying to understand why that might be fut failed. No idea. But i also can't see the relevance for merging this.

Sorry, I did not test hwi 2.1.0. However I could test hwi 2.1.0 with Ledger, as soon as I have time.

I don't think Ledger is that critical. This PR explicitely changed a lot for keepkey and Trezor and enabled the new jade's. So keepkey testing would be more important.

I'll merge that tomorrow and will create a ReleaseCandidate so that people from the chat can potentially test the ledger and you don't have to. There are some folks in there who might be able to help here (again).