Multiple internal nodes #1165
Merged
Multiple internal nodes #1165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM but as long as we can't practically test that with e.g. testnet, signet or elements, this is imho not practical to merge. Maybe convert to draft? |
|
Is it possible to mark as draft after creating the PR? Can't find out how... |
|
@k9ert added a test for this now |
| @@ -137,6 +137,8 @@ def add_node( | |||
| def add_internal_node( | |||
| self, | |||
| name, | |||
| network="mainnet", | |||
There was a problem hiding this comment.
Why not "main"? Looks like we have now main and mainnet that are basically the same.
|
If I try to "forget the node" with built-in node I face certain issues:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows setting up multiple internal nodes with different networks.
Currently, this will work only for one node per network, since the port will be already occupied, but the architecture already supports running multiple nodes of the same network on different ports, which is one of the 2 missing pieces we need in order to allow Quicksync option to have a background full sync (the second piece needed is way to migrate wallets between nodes).