-
Notifications
You must be signed in to change notification settings - Fork 241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Node manager #1146
Node manager #1146
Conversation
ben-kaufman
commented
May 4, 2021
•
edited
Loading
edited
- Add node and node manager classes
- Allow adding, removing, and switching between nodes
- Fix internal node functionality
- Remove old Bitcoin Core settings screen
- Migrate existing node configurations to the new format
- Fix the tests
- (Optional, maybe in another PR) Make wallets belong to a specific node (this could be a problem currently if user has multiple nodes of the same network)
- (Optional, maybe in another PR), allow multiple "built in" nodes for multiple networks.
Looks good to me and works pretty much as expected. |
There is imho one more question: How do we migrate the data on the user-side already using internal nodes? There are two possibilities:
What do you think? I tend to the second solution. The first one is pretty huge and should be a PR of itself. And maybe we want to still defer that mechanism until we might change persistence-technology. |
This should already work with migrating an existing internal node, I also tested and it worked well. The code responsible for this is at https://github.com/cryptoadvance/specter-desktop/pull/1146/files#diff-88c6a6cabbeff77aafe908b914ca9b08c2c0f5942b54b10b782fbc9dded8c6a6R569 |
There are known issues with the tor-test in cirrus, that's why this test is failing. Locally, all tests are green. That's why i'll merge this now nevertheless. |