Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update hidapi to 0.10.1 #1141

Merged
merged 1 commit into from
May 4, 2021
Merged

Conversation

leon-costa
Copy link
Contributor

The currently locked version of hidapi (0.7.99.post21) is quite old and fails to install on some systems. The dependencies no longer require this old version (HWI, bitbox02), so can it be updated?

I only ran pip-compile --generate-hashes --upgrade-package hidapi requirements.in.

@k9ert
Copy link
Collaborator

k9ert commented May 3, 2021

The CI is stuck due to:

"User is too new to use Community clusters! Please check with support!"

I just did that and hope to get some test-results soon!

Update:
Sorry, was too fast with this. I'm not sure this works for us. What we need here is an update of the dependencies which are depending on hidapi like HWI and bitbox2. Hidapi is coming indirectly to us, so we can't simply upgrade it.

@leon-costa
Copy link
Contributor Author

HWI and bitbox2 have both already updated to a more recent hidapi (see the links in my initial comment). pip-compile --upgrade-package installed the most recent hidapi that is still compatible with the dependencies.

@k9ert
Copy link
Collaborator

k9ert commented May 4, 2021

Yes, you're right. Other than us, they are (no longer) pinning to exact versions. As a result, their dependencies doesn't get reflected automatically in ours. Thanks, was not aware of this.

@k9ert
Copy link
Collaborator

k9ert commented May 4, 2021

I've checked the hashes and upgraded myself, found no difference. Merging.

@k9ert k9ert merged commit 43483f5 into cryptoadvance:master May 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants