Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tor.md #1129

Merged
merged 7 commits into from
May 19, 2021
Merged

Update tor.md #1129

merged 7 commits into from
May 19, 2021

Conversation

ben-kaufman
Copy link
Contributor

No description provided.

docs/tor.md Outdated

When using Specter Desktop, there might be certain cases where you would want to make calls over the Tor network. The simplest way to setup Tor integration with Specter Desktop is to click on the Get Started button of the welcome page aand follow the setup wizard, which will install and configure Tor for you. You can also access it but going to Settings -> Tor tab, and clicking on Setup Tor.

<img width="956" alt="Screen Shot 2021-04-24 at 10 42 08" src="https://user-images.githubusercontent.com/10667901/115953085-c4bd2f00-a4e9-11eb-8aa0-34e601681852.png">
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer to put the screenshots into this repo and that link is not this repo, no?
Either here:
https://github.com/cryptoadvance/specter-desktop/tree/master/screenshots
or also in the docs directory?

Copy link
Collaborator

@k9ert k9ert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, let's wait for the tests to be green and then merge.

@k9ert
Copy link
Collaborator

k9ert commented May 19, 2021

Damn, we've again a broken test:
https://cirrus-ci.com/task/5280178076123136?logs=cypress#L300

Error: SOCKSHTTPSConnectionPool(host='protonirockerxow.onion', port=443): Max retries exceeded with url: / (Caused by NewConnectionError('<urllib3.contrib.socks.SOCKSHTTPSConnection object at 0x7f0794125358>: Failed to establish a new connection: [Errno 99] Cannot assign requested address'))

This looks like a blocked tor-port. However 8 days ago, a guy from Cirrus confirmed that they unblocked the port. Rerunning ...

@k9ert
Copy link
Collaborator

k9ert commented May 19, 2021

It's rediculous. Now it's failing here:
https://cirrus-ci.com/task/4671521651163136?logs=cypress#L632

[2021-05-19 08:32:53,517] INFO in _internal: 127.0.0.1 - - [19/May/2021 08:32:53] "GET /static/pdf/jspdf.es.min.js HTTP/1.1" 200 -
Sending SIGUSR1 to 700
    --> 
    --> Mining to address bcrt1qutg7mx3y4da9g5k6nt3fvjuplk207y3kz7e706
[2021-05-19 08:32:55,622] INFO in _internal: 127.0.0.1 - - [19/May/2021 08:32:55] "GET /wallets/wallet/testwallet_ghost/history/ HTTP/1.1" 200 -
[2021-05-19 08:32:56,142] INFO in _internal: 127.0.0.1 - - [19/May/2021 08:32:56] "GET /wallets_loading/ HTTP/1.1" 200 -
[2021-05-19 08:32:56,143] INFO in _internal: 127.0.0.1 - - [19/May/2021 08:32:56] "GET /static/styles.css HTTP/1.1" 200 -
[2021-05-19 08:32:56,618] INFO in _internal: 127.0.0.1 - - [19/May/2021 08:32:56] "POST /wallets/wallet/testwallet_ghost/txlist HTTP/1.1" 200 -
[2021-05-19 08:32:56,733] INFO in _internal: 127.0.0.1 - - [19/May/2021 08:32:56] "GET /static/img/generate_icon.svg HTTP/1.1" 200 -
[2021-05-19 08:32:56,734] INFO in _internal: 127.0.0.1 - - [19/May/2021 08:32:56] "GET /static/img/snowflake.svg HTTP/1.1" 200 -
[2021-05-19 08:32:57,326] INFO in _internal: 127.0.0.1 - - [19/May/2021 08:32:57] "GET /wallets_loading/ HTTP/1.1" 200 -
3    1) Creates a wallet on specter
  0 passing (35s)
  1 failing
  1) Node Configured
       Creates a wallet on specter:
      Timed out retrying after 4000ms
      + expected - actual
      at Context.eval (http://localhost:25444/__cypress/tests?p=cypress/integration/spec_node_configured.js:126:23)
  (Results)
  ┌────────────────────────────────────────────────────────────────────────────────────────────────┐
  │ Tests:        1                                                                                │
  │ Passing:      0                                                                                │
  │ Failing:      1                                                                                │
  │ Pending:      0                                                                                │
  │ Skipped:      0                                                                                │
  │ Screenshots:  1                                                                                │
  │ Video:        true                                                                             │
  │ Duration:     34 seconds                                                                       │
  │ Spec Ran:     spec_node_configured.js                                                          │
  └────────────────────────────────────────────────────────────────────────────────────────────────┘
  (Screenshots)
  -  /tmp/cirrus-ci-build/cypress/screenshots/spec_node_configured.js/Node Configured    (1920x1080)
      -- Creates a wallet on specter (failed).png                                                   
  (Video)
  -  Started processing:  Compressing to 32 CRF                                                     
4  -  Finished processing: /tmp/cirrus-ci-build/cypress/videos/spec_node_configured.js   (19 seconds)
                          .mp4                                                                      
    Compression progress:  100%
────────────────────────────────────────────────────────────────────────────────────────────────────
                                                                                                    
  Running:  spec_wallet_send.js                                                             (5 of 6)

Line 23 in spec_node_configured.js would be cy.task("node:mine") however the screenshot hints that the full-balance-amount is violated:

        cy.task("node:mine")
        cy.get('#btn_continue').click()
        cy.get('#btn_transactions').click()
        cy.get('#fullbalance_amount')
        .should(($div) => {
            const n = parseFloat($div.text())
            expect(n).to.be.gt(0).and.be.lte(50)
        })

image
It's really annoying that the doesn't look stable but flaky right now. But let's use this rather easy PR to figure out what's going wrong. Ok, rerunning once again.

@k9ert
Copy link
Collaborator

k9ert commented May 19, 2021

Ok, the next run went fine:
https://cirrus-ci.com/task/5419131483717632
Rerunning again ...

@k9ert
Copy link
Collaborator

k9ert commented May 19, 2021

Aaand ... it's red again:
https://cirrus-ci.com/task/5113424964222976
The Tor-issue again:

[2021-05-19 09:12:36,263] INFO in _internal: 127.0.0.1 - - [19/May/2021 09:12:36] "POST /settings/tor HTTP/1.1" 200 -
23[2021-05-19 09:13:07,497] ERROR in settings: Failed to make test request over Tor.
Error: SOCKSHTTPSConnectionPool(host='protonirockerxow.onion', port=443): Max retries exceeded with url: / (Caused by NewConnectionError('<urllib3.contrib.socks.SOCKSHTTPSConnection object at 0x7f66f4f83908>: Failed to establish a new connection: [Errno 99] Cannot assign requested address'))

Rerunning ...

@k9ert
Copy link
Collaborator

k9ert commented May 19, 2021

Oh, wow, it's red, but the tor-issue disappeared and a very "new" issue appeared in spec_wallet_send.jy :
https://cirrus-ci.com/task/5879538849677312?logs=cypress#L757
And least, it seems related to the original tor-issue but not while setting-up and testing tor but later when grabbing infos from mempool:

[2021-05-19 09:36:36,870] WARNING in fee_estimation: Failed to fetch fee estimation from mempool.space Tor hidden service. Using Bitcoin Core instead. Error: SOCKSHTTPConnectionPool(host='mempoolhqx4isw62xs7abwphsq7ldayuidyx2v2oethdhhj6mlo2r6ad.onion', port=80): Max retries exceeded with url: /api/v1/fees/recommended (Caused by NewConnectionError('<urllib3.contrib.socks.SOCKSConnection object at 0x7fbd722cd588>: Failed to establish a new connection: [Errno 99] Cannot assign requested address'))

Let's rerun again ...

@k9ert
Copy link
Collaborator

k9ert commented May 19, 2021

Failed again:
https://cirrus-ci.com/task/4651184276373504?logs=cypress#L307
It's the first tor-issue again:

34[2021-05-19 09:49:27,845] ERROR in settings: Failed to make test request over Tor.
Error: SOCKSHTTPSConnectionPool(host='protonirockerxow.onion', port=443): Max retries exceeded with url: / (Caused by NewConnectionError('<urllib3.contrib.socks.SOCKSHTTPSConnection object at 0x7faaa82867b8>: Failed to establish a new connection: [Errno 99] Cannot assign requested address'))

@k9ert
Copy link
Collaborator

k9ert commented May 19, 2021

And it's green again. I have seen enough but can't merge it now. Updating the branch and let it run again ...
https://cirrus-ci.com/task/4836238445248512

@k9ert k9ert merged commit e908a84 into master May 19, 2021
@k9ert k9ert deleted the update-tor-doc branch August 31, 2021 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants