-
Notifications
You must be signed in to change notification settings - Fork 244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Problem: tx delivery performance is not benchmarked #916
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Solution: - add the first benchmark for tx delivery
mmsqe
reviewed
Mar 14, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that's allocation? |
ok, they are close enough, the result is not exactly the same in different runs |
mmsqe
approved these changes
Mar 14, 2023
mmsqe
pushed a commit
to mmsqe/cronos
that referenced
this pull request
Mar 16, 2023
…#916) Solution: - add the first benchmark for tx delivery
13 tasks
mmsqe
added a commit
that referenced
this pull request
Mar 16, 2023
* Problem: tx delivery performance is not benchmarked (#916) Solution: - add the first benchmark for tx delivery * Problem: go 1.20.2 is not used (#926) * Problem: go 1.20.2 is not used Solution: - update nixpkgs to recent master - re-enable coverage report for integration tests * enlarge timeout --------- Co-authored-by: mmsqe <[email protected]> * Problem: eth tx sender recovery is slow (#928) * Problem: eth tx sender recovery is slow Solution: - update ethermint dependency, do it once in ante handler and cache the result * fix build * update upstream * fix lint * fix versiondb * fix memiavl * fix upgrade integration test --------- Co-authored-by: mmsqe <[email protected]> * fix lint * fix test * point to rpc fix only * no report coverage --------- Co-authored-by: yihuang <[email protected]>
SPPRAGUE
pushed a commit
to SPPRAGUE/cronos
that referenced
this pull request
Jan 23, 2024
…n#932) * Problem: tx delivery performance is not benchmarked (crypto-org-chain#916) Solution: - add the first benchmark for tx delivery * Problem: go 1.20.2 is not used (crypto-org-chain#926) * Problem: go 1.20.2 is not used Solution: - update nixpkgs to recent master - re-enable coverage report for integration tests * enlarge timeout --------- Co-authored-by: mmsqe <[email protected]> * Problem: eth tx sender recovery is slow (crypto-org-chain#928) * Problem: eth tx sender recovery is slow Solution: - update ethermint dependency, do it once in ante handler and cache the result * fix build * update upstream * fix lint * fix versiondb * fix memiavl * fix upgrade integration test --------- Co-authored-by: mmsqe <[email protected]> * fix lint * fix test * point to rpc fix only * no report coverage --------- Co-authored-by: yihuang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solution:
Test Results
GetParams
.👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻
PR Checklist:
make
)make test
)go fmt
)golangci-lint run
)go list -json -m all | nancy sleuth
)Thank you for your code, it's appreciated! :)