Problem: no integration test for websocket rpc endpoint #370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yihuang
requested review from
JayT106 and
calvinaco
and removed request for
a team
Codecov Report
@@ Coverage Diff @@
## main #370 +/- ##
===========================================
+ Coverage 21.51% 41.06% +19.54%
===========================================
Files 27 30 +3
Lines 1729 1505 -224
===========================================
+ Hits 372 618 +246
+ Misses 1324 841 -483
- Partials 33 46 +13
|
yihuang
force-pushed
the
test-ws
branch
2 times, most recently
from
b9114c5 to
f664407
Compare
Closes: crypto-org-chain#364 Solution: - add cronos-ws provider to run exiting test cases on websocket endpoint - add websocket subscription test cases - update ethermint to fix websocket bugs
yihuang
commented
Mar 1, 2022
| @@ -164,7 +164,7 @@ replace ( | |||
| // See https://github.com/tecbot/gorocksdb/pull/216 | |||
| github.com/tecbot/gorocksdb => github.com/cosmos/gorocksdb v1.1.1 | |||
|
|
|||
| github.com/tharsis/ethermint => github.com/crypto-org-chain/ethermint v0.10.0-alpha1-cronos-6 | |||
| github.com/tharsis/ethermint => github.com/crypto-org-chain/ethermint v0.10.0-alpha1-cronos-6.0.20220301081024-4ec8b052c769 | |||
There was a problem hiding this comment.
yihuang
commented
Mar 1, 2022
| @@ -30,7 +30,6 @@ | |||
| def test_basic(cluster): | |||
| w3 = cluster.w3 | |||
| assert w3.eth.chain_id == 777 | |||
| assert w3.eth.get_balance(ADDRS["community"]) == 10000000000000000000000 | |||
There was a problem hiding this comment.
it only works if this is the very first test case to run, but it's not guaranteed.
yihuang
commented
Mar 1, 2022
| @@ -47,7 +47,7 @@ def geth(tmp_path_factory): | |||
| yield from setup_geth(path, 8545) | |||
|
|
|||
|
|
|||
| @pytest.fixture(scope="session", params=["cronos", "geth"]) | |||
| @pytest.fixture(scope="session", params=["cronos", "geth", "cronos-ws"]) | |||
There was a problem hiding this comment.
all the test cases which use the cluster fixture will be run an extra time against Cronos WebSocket endpoint.
yihuang
added a commit
to yihuang/cronos
that referenced
this pull request
Mar 1, 2022
…to-org-chain#370) Solution: - backport ethermint fix. - backport websockets integration tests.
13 tasks
yihuang
added a commit
to yihuang/cronos
that referenced
this pull request
Mar 2, 2022
…hain#370) * Problem: no integration test for websocket rpc endpoint Closes: crypto-org-chain#364 Solution: - add cronos-ws provider to run exiting test cases on websocket endpoint - add websocket subscription test cases - update ethermint to fix websocket bugs * fix python linter * changelog * fix python linter
yihuang
added a commit
to yihuang/cronos
that referenced
this pull request
Mar 2, 2022
…hain#370) * Problem: no integration test for websocket rpc endpoint Closes: crypto-org-chain#364 Solution: - add cronos-ws provider to run exiting test cases on websocket endpoint - add websocket subscription test cases - update ethermint to fix websocket bugs * fix python linter * changelog * fix python linter
yihuang
added a commit
that referenced
this pull request
Mar 3, 2022
#373) * Problem: websocket push duplicated messages to client (backport: #370) Solution: - backport ethermint fix. - backport websockets integration tests. * changelog * Update CHANGELOG.md * gomod2nix * Problem: no integration test for websocket rpc endpoint (#370) * Problem: no integration test for websocket rpc endpoint Closes: #364 Solution: - add cronos-ws provider to run exiting test cases on websocket endpoint - add websocket subscription test cases - update ethermint to fix websocket bugs * fix python linter * changelog * fix python linter * use a tag in ethermint repo
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #364
Solution:
👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻
PR Checklist:
make)make test)go fmt)golangci-lint run)go list -json -m all | nancy sleuth)Thank you for your code, it's appreciated! :)