Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Problem: simulations don't simulate cronos-related functionality #150

Closed
tomtau opened this issue Oct 7, 2021 · 1 comment
Closed

Problem: simulations don't simulate cronos-related functionality #150

tomtau opened this issue Oct 7, 2021 · 1 comment
Assignees
@yihuang @thomas-nguy
Labels
tests This issue is related to unit or integration tests

Comments

@tomtau
Copy link
Contributor

tomtau commented Oct 7, 2021

There are three core things and none of them seems tested:

  1. EVM / Ethermint operations
  2. gravity bridge operations
  3. cronos custom operations (e.g. ConvertVouchers)

not sure about the EVM, as the current Cosmos SDK simulation code may hardcode keypair types to secp256k1 (not ethsecp256k1)... but at least cronos custom operations may be possible by simply adding func (am AppModule) WeightedOperations(simState module.SimulationState) []simtypes.WeightedOperation generator to the module
@tomtau tomtau added the tests This issue is related to unit or integration tests label Oct 28, 2021
@tomtau
Copy link
Contributor Author

tomtau commented Oct 28, 2021

related issue evmos/ethermint#658

tomtau added a commit to tomtau/cronos that referenced this issue Nov 15, 2021
@tomtau
Problem: simulations don't simulate cronos-related functionality (fixes
5c72944 
crypto-org-chain#150)

Solution:
- removed the sims pipelines temporarily:
1) sims-protected doesn't appear to be ever executed
2) sims take a lot of CI time (~1.5hour each) despite not being useful
- currently blocked by evmos/ethermint#658 cosmos/cosmos-sdk#10495 etc.
@tomtau tomtau closed this as completed in 4725cf0 Nov 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yihuang yihuang

@thomas-nguy thomas-nguy

Labels
tests This issue is related to unit or integration tests
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@yihuang @tomtau @thomas-nguy