Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: fee collection not compatible with parallel execution #237

Merged
merged 1 commit into from
Mar 28, 2024

Problem: no efficient way to collect fee

f04a9c9
Select commit
Loading
Failed to load commit list.
Merged

Problem: fee collection not compatible with parallel execution #237

Problem: no efficient way to collect fee
f04a9c9
Select commit
Loading
Failed to load commit list.
GitHub Advanced Security / CodeQL succeeded Mar 28, 2024 in 6s

2 new alerts

New alerts in code changed by this pull request

  • 2 warnings

See annotations below for details.

View all branch alerts.

Annotations

Check warning on line 201 in x/bank/module.go

See this annotation in the file changed.

Code scanning / CodeQL

Panic in BeginBock or EndBlock consensus methods Warning

path flow from Begin/EndBlock to a panic call
path flow from Begin/EndBlock to a panic call
path flow from Begin/EndBlock to a panic call
path flow from Begin/EndBlock to a panic call
path flow from Begin/EndBlock to a panic call

Check warning on line 190 in testutil/integration/router.go

See this annotation in the file changed.

Code scanning / CodeQL

Iteration over map Warning test

Iteration over map may be a possible source of non-determinism