Prepare for lib release - Update build setup to copy generated protos #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A week ago when I was doing local npm registry releases and testing I realized initially that proto js files were missing in the output build.
@calvinaco suggested to turn the config of
allowJstotrue, this worked fine and it produced a working build that I was able to test.One issue with that config is the fact that
tscwould output a lot of warnings and errors whenallowJswas turned on and it was a known issue.Generating Type Definitions from Javascript is blocked by requiring private name microsoft/TypeScript#37832
The solution in this PR involves just moving the generated folder to the output directory same technique being used by
cosmjsand it has worked really great in the tests I have done so far