Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: (Fix #1) Missing project setup #7

Merged
merged 1 commit into from
Oct 5, 2020

Conversation

calvinaco
Copy link
Collaborator

Solution: Setup TypeScript projects with GitHub actions

@calvinaco calvinaco linked an issue Sep 24, 2020 that may be closed by this pull request
Solution: Setup TypeScript projects with GitHub actions
@calvinaco calvinaco force-pushed the feature/1-project-setup branch from 695a3b1 to f1fb78d Compare September 24, 2020 22:34
Copy link
Contributor

@cdc-Hitesh cdc-Hitesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@calvinaco Initial setup looks good to go. Other folders will be added moving forward.
Do we need to keep GitHub actions?

@calvinaco
Copy link
Collaborator Author

@calvinaco Initial setup looks good to go. Other folders will be added moving forward.
Do we need to keep GitHub actions?

Yes, more files will be added later, the GitHub actions are newly created. Before we use Travis CI.

@cdc-Hitesh
Copy link
Contributor

Hey @foreseaz ,
Can we merge this PR?

Copy link

@foreseaz foreseaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@calvinaco calvinaco merged commit 29683b5 into master Oct 5, 2020
@calvinaco calvinaco deleted the feature/1-project-setup branch November 23, 2020 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Problem: Missing new jslib project
4 participants