-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Offline Signing Support & TxDecoder #298
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…slib into feature-offlineSigning-MsgSend
…dc-Hitesh/chain-jslib into offlineSigning-documentation
Problem: Feature offline signing msg send
Problem: Offline signing documentation
…into tx-revamp-dev
…om/cdc-Hitesh/chain-jslib into enhancement-offlineSigning-GOVERNANCE
- CommunityPool - ParameterChangeProposal - Refactoring
Co-authored-by: Calvin Lau <[email protected]>
…into tx-revamp-dev
…n-jslib into eslint-ruleFixes
Review 1: Eslint Fix | TxDecoder | OfflineSigning | IBCLightClient.ClientState
Review 2: Consensus State | TxDecoder Support | MsgCreateClient Fix | owTypes Fix
…hain-jslib into IBC-connection-msgTypes
…sh/chain-jslib into IBC-connection-msgTypes
Review 3: MsgUpdateClient .toCosmosJSON | LightClient.Header
This pull request introduces 1 alert when merging 1624ff8 into 091d2bd - view on LGTM.com new alerts:
|
…hain-jslib into IBC-connection-msgTypes
Review 4 `MsgConnectionOpenConfirm` support | TxDecoder | `MsgConnectionOpenTry` | fromCosmosJSON()
This pull request introduces 1 alert when merging c82b19b into 091d2bd - view on LGTM.com new alerts:
|
calvinaco
changed the title
[NFM] [Review-3] : Offline Signing Support & TxDecoder
Offline Signing Support & TxDecoder
Aug 4, 2021
@calvinaco @crypto-3dd |
calvinaco
approved these changes
Aug 10, 2021
crypto-eddy
approved these changes
Aug 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.