Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: Support IBC MsgUpdateClient #286

Merged

Conversation

cdc-Hitesh
Copy link
Contributor

Fixes #284

@codecov
Copy link

codecov bot commented Jun 22, 2021

Codecov Report

Merging #286 (d7832d3) into tx-revamp-dev (b96ed43) will increase coverage by 7.58%.
The diff coverage is 98.22%.

Impacted file tree graph

@@                Coverage Diff                @@
##           tx-revamp-dev     #286      +/-   ##
=================================================
+ Coverage          89.34%   96.92%   +7.58%     
=================================================
  Files                101      132      +31     
  Lines               3613     5666    +2053     
  Branches             261      368     +107     
=================================================
+ Hits                3228     5492    +2264     
+ Misses               385      174     -211     
Impacted Files Coverage Δ
lib/src/client/client.ts 80.95% <ø> (ø)
lib/src/transaction/msg/bank/msgsend.spec.ts 100.00% <ø> (ø)
lib/src/transaction/msg/bank/msgsend.ts 100.00% <ø> (ø)
lib/src/transaction/msg/gov/ow.types.ts 94.73% <ø> (ø)
.../src/transaction/msg/staking/MsgBeginRedelegate.ts 91.89% <ø> (ø)
.../src/transaction/msg/staking/MsgCreateValidator.ts 94.23% <ø> (ø)
lib/src/utils/txDecoder.spec.ts 100.00% <ø> (ø)
...action/msg/gov/proposal/SoftwareUpgradeProposal.ts 87.87% <75.00%> (+37.87%) ⬆️
.../msg/gov/proposal/CancelSoftwareUpgradeProposal.ts 95.00% <80.00%> (+41.66%) ⬆️
lib/src/transaction/signable.ts 93.88% <81.81%> (-0.53%) ⬇️
... and 108 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d51008d...d7832d3. Read the comment docs.

@cdc-Hitesh cdc-Hitesh changed the base branch from dev to tx-revamp-dev July 8, 2021 05:26
@calvinaco
Copy link
Collaborator

Need to resolve conflicts

@cdc-Hitesh
Copy link
Contributor Author

Need to resolve conflicts

@calvinaco

After seeing the actual json object, I am doing some changes to this one.
Working on writing fromCosmosJSON method

@cdc-Hitesh
Copy link
Contributor Author

@calvinaco @eddycpc
I have included changes for 2 message types here.
As I found out the onchain message JSON structure changed a few assumptions in the previous code.

I have left a few Todos inside.

@crypto-eddy crypto-eddy merged commit da8cc2f into crypto-org-chain:tx-revamp-dev Jul 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Problem: Support IBC core message types
3 participants