Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Ready-1] Problem: Support offline signing for GOVERNANCE module #253

Conversation

cdc-Hitesh
Copy link
Contributor

Fixes #245

@cdc-Hitesh cdc-Hitesh requested a review from calvinaco as a code owner June 4, 2021 11:24
@cdc-Hitesh cdc-Hitesh changed the title Problelm: Support offline signing for GOVERNANCE module [NFM] Problem: Support offline signing for GOVERNANCE module Jun 4, 2021
@codecov
Copy link

codecov bot commented Jun 11, 2021

Codecov Report

Merging #253 (4e0c80e) into tx-revamp-dev (b96ed43) will increase coverage by 3.38%.
The diff coverage is 93.87%.

Impacted file tree graph

@@                Coverage Diff                @@
##           tx-revamp-dev     #253      +/-   ##
=================================================
+ Coverage          89.34%   92.73%   +3.38%     
=================================================
  Files                101      107       +6     
  Lines               3613     4004     +391     
  Branches             261      290      +29     
=================================================
+ Hits                3228     3713     +485     
+ Misses               385      291      -94     
Impacted Files Coverage Δ
lib/src/transaction/msg/gov/ow.types.ts 94.73% <ø> (ø)
.../src/transaction/msg/staking/MsgBeginRedelegate.ts 91.89% <ø> (ø)
.../src/transaction/msg/staking/MsgCreateValidator.ts 94.23% <ø> (ø)
...action/msg/gov/proposal/SoftwareUpgradeProposal.ts 87.87% <75.00%> (+37.87%) ⬆️
.../msg/gov/proposal/CancelSoftwareUpgradeProposal.ts 95.00% <80.00%> (+41.66%) ⬆️
...ion/msg/gov/proposal/CommunityPoolSpendProposal.ts 87.09% <84.61%> (ø)
...ransaction/msg/gov/proposal/ParamChangeProposal.ts 95.65% <87.50%> (ø)
lib/src/transaction/msg/gov/MsgSubmitProposal.ts 93.93% <92.30%> (+46.32%) ⬆️
lib/src/core/cro.ts 100.00% <100.00%> (ø)
lib/src/transaction/common/constants/typeurl.ts 75.60% <100.00%> (+35.06%) ⬆️
... and 24 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8127701...4e0c80e. Read the comment docs.

@cdc-Hitesh cdc-Hitesh changed the title [NFM] Problem: Support offline signing for GOVERNANCE module [Ready for Review] Problem: Support offline signing for GOVERNANCE module Jun 11, 2021
@cdc-Hitesh cdc-Hitesh changed the title [Ready for Review] Problem: Support offline signing for GOVERNANCE module [Ready] Problem: Support offline signing for GOVERNANCE module Jun 14, 2021
@cdc-Hitesh cdc-Hitesh changed the title [Ready] Problem: Support offline signing for GOVERNANCE module [Ready-1] Problem: Support offline signing for GOVERNANCE module Jun 14, 2021
@cdc-Hitesh cdc-Hitesh requested a review from calvinaco June 15, 2021 06:05
@calvinaco calvinaco merged commit 284c785 into crypto-org-chain:tx-revamp-dev Jun 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants