Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(smoketest): add quarkus-petclinic sample #801

Merged
merged 1 commit into from
Feb 11, 2025

Conversation

andrewazores
Copy link
Member

@andrewazores andrewazores commented Feb 10, 2025

Welcome to Cryostat! 👋

Before contributing, make sure you have:

  • Read the contributing guidelines
  • Linked a relevant issue which this PR resolves
  • Linked any other relevant issues, PR's, or documentation, if any
  • Resolved all conflicts, if any
  • Rebased your branch PR on top of the latest upstream main branch
  • Attached at least one of the following labels to the PR: [chore, ci, docs, feat, fix, test]
  • Signed all commits using a GPG signature

To recreate commits with GPG signature git fetch upstream && git rebase --force --gpg-sign upstream/main


Depends on cryostatio/test-applications#32

Description of the change:

Adds a more complex sample application for testing.

Motivation for the change:

This sample application is more interactive than many of the others, and this one includes quarkus-jfr and hibernate-jfr so can be used as a test for the functionalities integrating those event templates and automated rules.

See #750
See #733

How to manually test:

  1. Check out PR
  2. ./smoketest.bash -Ot quarkus-petclinic. If feat(quarkus): add petclinic example test-applications#32 isn't merged yet, check out that PR and cd quarkus-petclinic ; TAGS=latest ./build.bash to build it locally first.
  3. Wait for everything to come up. Open https://localhost:8443 Cryostat UI. Open http://localhost:10011 petclinic UI.
  4. In Cryostat UI, ensure petclinic sample is discovered. Go to Event Types and ensure that hibernate events are registered. quarkus-jfr events should also be registered but this doesn't always seem to happen eagerly.
  5. Go to Automated Rules and enable the hibernate rule. Ensure that a recording is created on the petclinic.
  6. Go to Recordings and manually create a recording using the quarkus preset event template on the petclinic.
  7. Go to petclinic UI and click around for a while.
  8. Go back to Cryostat UI and download one of the active recordings. jfr summary myfile.jfr | grep -e 'quarkus\|hibernate' should return lots of results.

Copy link

This PR/issue depends on:

Copy link
Member

@aptmac aptmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, works well

@andrewazores andrewazores merged commit 8ac65c1 into cryostatio:main Feb 11, 2025
10 of 11 checks passed
@andrewazores andrewazores deleted the petclinic branch February 11, 2025 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants