Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporarily disable metrics endpoint #190

Merged
merged 4 commits into from
Apr 12, 2021
Merged

Conversation

ebaron
Copy link
Member

@ebaron ebaron commented Apr 9, 2021

This PR temporarily disables the metrics endpoint until #180 is resolved. This is done by setting the metrics address to 0. From manager.Options:

	// MetricsBindAddress is the TCP address that the controller should bind to
	// for serving prometheus metrics.
	// It can be set to "0" to disable the metrics serving.
	MetricsBindAddress string

With metrics disabled, the kube-rbac-proxy is no longer required, so this PR disables it. This avoids the symptoms of #180.

@ebaron ebaron requested a review from andrewazores April 9, 2021 23:57
@andrewazores
Copy link
Member

There are some other auth_proxy_*.yamls in config/rbac which look like they can be commented out in the kustomization.yaml too. I still have a service/container-jfr-operator-controller-manager-metrics-service for instance, which I don't think is needed if the kube-rbac-proxy container isn't running, right?

@ebaron
Copy link
Member Author

ebaron commented Apr 12, 2021

Good eye. Those are commented out too now.

@andrewazores
Copy link
Member

I think the bundle needs to be regenerated as well to remove the YAMLs which have already been copied. I tried make bundle on my own and it didn't remove them, but rm -rf bundle && make bundle looks like it regenerates the expected result in the end. I built/bundled/deployed this myself and everything looks good from a manual check over, so I think that's the last thing needed here.

@ebaron
Copy link
Member Author

ebaron commented Apr 12, 2021

Thanks for noticing that too. Starting with a fresh bundle directory removed the leader election role/binding files as well. I noticed that this gets folded into the role defined in the CSV though, so those files should be unnecessary.

@ebaron ebaron merged commit 563158e into cryostatio:main Apr 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants