fix(ci): add ITEST_IMG_VERSION arg to repeated-tests bash script #1153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't think it matters much either way. I suppose the |
andrewazores
approved these changes
Oct 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1152
Also, I didn't mention this before but there is a mismatch of the itest output filename logs between the bash script and the mvn build executions.
That's why in the split-container-pr #1138, I had to change the
run: ls -1dt target/cryostat-itest-*.log | head -n1 | xargs cat->cryostat-itests.The pom.xml here on this line:
https://github.com/cryostatio/cryostat/blob/132459fbefed742f00c26058b184b2889f790aa3/pom.xml#L633
outputs the file as
cryostat-itest-timestamp.logwhile the script doescryostat-itests-timestamp.logsincecryostat.itest.containerName="cryostat-itest".Which should be changed here?