Load strings from external file instead of using hard coded values #65
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've extracted the most important strings from all files and put them into the
lang/en_US.json
file.There are two strings that are important and weren't extracted because I was unable to extract without breaking the sites functionality.
This is due to them having links in them that I would have had to either include in the translation file, which could cause breaks over time through e.g. method or URL changes or alternatively make multiple strings that only include the text parts, leaving the links out.
There probably also is a third way more elegant way of doing this, but I was unable to get something like that to work with my limited Vue.js knowledge.
There are also some other "hacky" ways I used for other translations that can probably be done more elegant.
This is only the first step to localization, I might implement the language switching mechanism too at some point, but I wouldn't mind if someone else did.
Closes #45